hachikuji opened a new pull request #9353:
URL: https://github.com/apache/kafka/pull/9353


   Before `AlterIsr` with KIP-497, the controller would register watches in 
Zookeeper for each reassigning partition so that it could be notified 
immediately when the ISR was expanded and the reassignment could be completed. 
This notification is not needed with the latest IBP when `AlterIsr` is enabled 
because the controller will see all
   
   There is one subtle detail. If we are in the middle of a roll in order to 
bump the IBP, then it is possible for the controller to be on the latest IBP 
while some of the brokers are still on the older one. In this case, the brokers 
on the older IBP will not send `AlterIsr`, but we can still rely on the delayed 
notification through the `isr_notifications` path to complete reassignments. 
This seems like a reasonable tradeoff since it should be a short window before 
the roll is completed.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to