rondagostino commented on a change in pull request #9378:
URL: https://github.com/apache/kafka/pull/9378#discussion_r500464258
##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -983,7 +988,10 @@ def _topic_command_connect_setting(self, node,
force_use_zk_connection):
bootstrap server, otherwise returns zookeeper connection string.
"""
if not force_use_zk_connection and
self.all_nodes_topic_command_supports_bootstrap_server():
- connection_setting = "--bootstrap-server %s" %
(self.bootstrap_servers(self.security_protocol))
+ if self.interbroker_security_protocol == SecurityConfig.PLAINTEXT:
+ connection_setting = "--bootstrap-server %s" %
(self.bootstrap_servers(self.interbroker_security_protocol))
+ else:
+ connection_setting = "--bootstrap-server %s" %
(self.bootstrap_servers(self.security_protocol))
Review comment:
This code is identifying the port to contact when we are using
`--bootstrap-server` instead of `--zookeeper`, and we use the port associated
with `PLAINTEXT` rather than `SASL_{PLAINTEXT,SSL}` or `SSL` if `PLAINTEXT` is
in use. The assumption is that if `PLAINTEXT` is in use it will be the
inter-broker security protocol rather than (or in addition to) the client
security protocol, which is the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
