tombentley commented on pull request #9397:
URL: https://github.com/apache/kafka/pull/9397#issuecomment-706196779


   @efeg the javadoc for `KafkaAdminClient` says "Users should not refer to 
this class directly", so just adding the thread-safety note to 
`KafkaAdminClient` probably isn't so helpful, we should add it to `Admin` too. 
Though since that's an interface probably some wording like "The instances 
returned from the {@code create} methods are guaranteed to be thread safe" 
would be better.
   
   This is also an opportunity to improve the rather scant Javadoc for `Admin`. 
Compare it to the extensive Javadoc for `KafkaProducer` and `KafkaConsumer`.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to