zhaohaidao commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r502752681
##########
File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala
##########
@@ -555,11 +555,11 @@ class TransactionsTest extends KafkaServerTestHarness {
try {
// Now that the transaction has expired, the second send should fail
with a ProducerFencedException.
producer.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic1,
null, "2", "2", willBeCommitted = false)).get()
- fail("should have raised a ProducerFencedException since the transaction
has expired")
+ fail("should have raised a TransactionTimeOutException since the
transaction has expired")
} catch {
- case _: ProducerFencedException =>
+ case _: TransactionTimeOutException =>
case e: ExecutionException =>
- assertTrue(e.getCause.isInstanceOf[ProducerFencedException])
+ assertTrue(e.getCause.isInstanceOf[TransactionTimeOutException])
Review comment:
Thanks for your reminding.
I added a case to verify the producer remains usable after the timeout
https://github.com/apache/kafka/pull/9311/files#diff-231b8aacf24c8458f322b4a9f872d4efR584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
