thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-706587502
@vvcephei You were right. Duplication in WrappungNullables was my biggest concern. I've refactored it in the way you proposed it. It was not a big deal :) So have no worries! Just a suggestion regarding the API of SateStoreContext and ProcessorContext: Wouldn't it be possible to extract the properties that belong to the context of the task into a seperate entity (TaskContext) and provide getter in StateStoreContext and ProcessorContext to retrieve the TaskContext? Designing it this way would still decouple StateStoreContext and ProcessorContext but at the same time, it would be easier to write common code that only needs to have information from the TaskContext. This would also transport the semantics of the relationships between Task, Processor and State to the "context" level. I know that this is late feedback on this refactoring since the KIP has already been accepted, but I just wanted to share my thoughs on this before it is a public API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
