rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r504726150
########## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ########## @@ -813,8 +852,9 @@ case class OffsetTruncationState(offset: Long, truncationCompleted: Boolean) { override def toString: String = "offset:%d-truncationCompleted:%b".format(offset, truncationCompleted) } -case class OffsetAndEpoch(offset: Long, leaderEpoch: Int) { +case class OffsetAndEpoch(offset: Long, leaderEpoch: Int, lastFetchedEpoch: Option[Int] = None) { Review comment: I had initially added another class because I didn't want to change `OffsetAndEpoch`, but I removed that because it looked like too many similar classes. Your suggestion to use InitialFetchState sounds much better, updated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org