cadonna commented on a change in pull request #9416:
URL: https://github.com/apache/kafka/pull/9416#discussion_r505572558
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -908,6 +908,7 @@ class GroupCoordinator(val brokerId: Int,
* @param offsetTopicPartitionId The partition we are now leading
*/
def onElection(offsetTopicPartitionId: Int): Unit = {
+ info(s"Electing as the group coordinator for partition
$offsetTopicPartitionId")
Review comment:
Shouldn't that read `Elected as the group coordinator ...`?
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##########
@@ -311,6 +311,7 @@ class TransactionCoordinator(brokerId: Int,
* @param coordinatorEpoch The partition coordinator (or leader) epoch from
the received LeaderAndIsr request
*/
def onElection(txnTopicPartitionId: Int, coordinatorEpoch: Int): Unit = {
+ info(s"Becoming the txn coordinator for partition $txnTopicPartitionId at
epoch $coordinatorEpoch")
Review comment:
Do you also plan to change this to `Elected as ...`?
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##########
@@ -329,6 +330,7 @@ class TransactionCoordinator(brokerId: Int,
* are resigning after receiving a StopReplica
request from the controller
*/
def onResignation(txnTopicPartitionId: Int, coordinatorEpoch: Option[Int]):
Unit = {
+ info(s"Resigning the txn coordinator for partition $txnTopicPartitionId at
epoch $coordinatorEpoch")
Review comment:
This still needs to be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
