[ 
https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214819#comment-17214819
 ] 

Matthias J. Sax commented on KAFKA-8531:
----------------------------------------

[~grussell] of course. Note thought, that we put this change "on hold", because 
of backward compatibility concerns: if an app connects to older brokers, using 
`-1` would be invalid and thus we cannot set it as default easily. – Of course, 
users can still specify `-1` manually if they use broker that are recent enough.

We could still update the docs and call out that for newer broker, `-1` is also 
a valid config (not sure if your comment was targeting this point?). Feel free 
to do a small PR to just update the docs.

> Change default replication factor config
> ----------------------------------------
>
>                 Key: KAFKA-8531
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8531
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 2.3.0
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>              Labels: kip
>
> With KAFKA-8305, AdminClient allows to create topics based on the broker 
> default replication factor.
> Kafka Streams sets `replication.factor` to 1 by default atm, to give a good 
> out-of-the-box user experience. The problem is, that people may need to 
> change the config if they push an application to production.
> We should change the default to `-1` to exploit the new AdminClient feature. 
> This won't impact the out-of-the-box experience and may avoids the need to 
> change the setting when pushing an application to production.
> We piggy-back this change to the original KIP: 
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-464%3A+Defaults+for+AdminClient%23createTopic]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to