feyman2016 commented on a change in pull request #9270:
URL: https://github.com/apache/kafka/pull/9270#discussion_r506001704
##########
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
##########
@@ -3789,6 +3844,41 @@ class GroupCoordinatorTest {
requireKnownMemberId: Boolean = false):
Future[JoinGroupResult] = {
val (responseFuture, responseCallback) = setupJoinGroupCallback
+
EasyMock.expect(replicaManager.getMagic(EasyMock.anyObject())).andReturn(Some(RecordBatch.MAGIC_VALUE_V1)).anyTimes()
+ EasyMock.replay(replicaManager)
+
+ groupCoordinator.handleJoinGroup(groupId, memberId, groupInstanceId,
+ requireKnownMemberId, "clientId", "clientHost", rebalanceTimeout,
sessionTimeout, protocolType, protocols, responseCallback)
+ responseFuture
+ }
+
+ private def sendStaticJoinGroupWithPersistence(groupId: String,
Review comment:
Yes, perhaps I should reuse the function: `sendStaticJoinGroup`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
