[GitHub] [kafka] chia7712 commented on a change in pull request #9406: KAFKA-10520; Ensure transactional producers poll if leastLoadedNode not available with max.in.flight=1

[GitBox]

chia7712 commented on a change in pull request #9406:
URL: https://github.com/apache/kafka/pull/9406#discussion_r509082243



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##########
@@ -512,21 +523,15 @@ public boolean isRunning() {
         return running;
     }
 
-    private Node awaitNodeReady(FindCoordinatorRequest.CoordinatorType 
coordinatorType) throws IOException {
-        Node node = coordinatorType != null ?
-                transactionManager.coordinator(coordinatorType) :
-                client.leastLoadedNode(time.milliseconds());
-
+    private void awaitNodeReady(Node node, 
FindCoordinatorRequest.CoordinatorType coordinatorType) throws IOException {
         if (node != null && NetworkClientUtils.awaitReady(client, node, time, 
requestTimeoutMs)) {

Review comment:
       ```node != null``` Is this check necessary?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org