jsancio commented on a change in pull request #9418:
URL: https://github.com/apache/kafka/pull/9418#discussion_r512195616
##########
File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala
##########
@@ -216,11 +216,9 @@ class KafkaNetworkChannel(time: Time,
endpoints.put(id, node)
}
- def postInboundRequest(header: RequestHeader,
- request: AbstractRequest,
- onResponseReceived: ResponseHandler): Unit = {
+ def postInboundRequest(request: AbstractRequest, onResponseReceived:
ResponseHandler): Unit = {
Review comment:
> I don't think that's right. It only delivers responses for outbound
requests (in other words, inbound responses).
Hmm. I misspoke a bit. I should have said that `pollInboundResponses`
returns both inbound requests and responses. These are my observations:
`postInboundRequest` puts requests in `undelivered`:
https://github.com/apache/kafka/pull/9418/files#diff-c9b2a05e69be1d2391d91a33f408eab4fde1245d4ea9cf9f52305c8cb89208ceR224
`pollInboundResponses` returns everything in `undelivered`:
https://github.com/apache/kafka/pull/9418/files#diff-c9b2a05e69be1d2391d91a33f408eab4fde1245d4ea9cf9f52305c8cb89208ceR201-R202
The raft client gets all of the inbound messages (requests and reponses) by
calling `receive` which in term calls `pollInboundResponses`:
https://github.com/apache/kafka/pull/9418/files#diff-1da15c51e641ea46ea5c86201ab8f21cfee9e7c575102a39c7bae0d5ffd7de39L1596
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
