apovzner commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r512888360
##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -526,10 +527,14 @@ private[kafka] abstract class
AbstractServerThread(connectionQuotas: ConnectionQ
if (channel != null) {
debug(s"Closing connection from
${channel.socket.getRemoteSocketAddress()}")
connectionQuotas.dec(listenerName, channel.socket.getInetAddress)
- CoreUtils.swallow(channel.socket().close(), this, Level.ERROR)
- CoreUtils.swallow(channel.close(), this, Level.ERROR)
+ closeSocket(channel)
}
}
+
+ protected def closeSocket(channel: SocketChannel): Unit = {
Review comment:
this method is also called from the derived class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
