[GitHub] [kafka] chia7712 commented on a change in pull request #9507: KAFKA-10628: remove all the unnecessary parameters from the tests which are using TopologyTestDriver

[GitBox]

chia7712 commented on a change in pull request #9507:
URL: https://github.com/apache/kafka/pull/9507#discussion_r513926844



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java
##########
@@ -92,8 +92,6 @@ public KTableKTableForeignKeyJoinIntegrationTest(final 
boolean leftJoin,
     public void before() {
         final String safeTestName = safeUniqueTestName(getClass(), testName);

Review comment:
       Is this method ```safeUniqueTestName``` useless now? It seems to me it 
tries to produce different name for each test case. Is it possible to make 
those tests flaky?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org