cadonna commented on a change in pull request #9543:
URL: https://github.com/apache/kafka/pull/9543#discussion_r518057272
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -719,8 +718,7 @@ private KafkaStreams(final InternalTopologyBuilder
internalTopologyBuilder,
}
// create the stream thread, global update thread, and cleanup thread
- threads = new StreamThread[numStreamThreads];
-
+ threads = new LinkedList<>();
Review comment:
Currently only the constructor adds elements to the list. All other
accesses afterwards are read-only. So, we would not need a synchronized list as
far as I see. When we implement the add and remove streams thread APIs, we
probably need synchronization. My proposal is to leave it a synchronized list
now just in case we forget to think about it afterwards and then to reconsider
how we synchronize the accesses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
