hachikuji commented on pull request #9563: URL: https://github.com/apache/kafka/pull/9563#issuecomment-723207603
@chia7712 Thanks for the reviews. I pushed an update to address your comments. I was a little concerned about the garbage created from the `MessageSize` objects, so I changed the generated code to use an accumulator pattern instead. Not sure it was really worth it, but let me know what you think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org