hachikuji commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r518989756
########## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ########## @@ -194,7 +107,27 @@ private ProduceRequest build(short version, boolean validate) { ProduceRequest.validateRecords(version, records); } } - return new ProduceRequest(version, acks, timeout, partitionRecords, transactionalId); + + List<ProduceRequestData.TopicProduceData> tpd = partitionRecords Review comment: We could probably also compute `partitionSizes` lazily. I think the broker is the only one that uses it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org