splett2 commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519894386
##########
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##########
@@ -1894,10 +1894,10 @@ class ReplicaManagerTest {
// each replica manager is for a broker
val rm0 = new ReplicaManager(config0, metrics, time, kafkaZkClient, new
MockScheduler(time), mockLogMgr0,
- new AtomicBoolean(false), QuotaFactory.instantiate(config0, metrics,
time, ""),
+ new AtomicBoolean(false), quotaManager,
brokerTopicStats1, metadataCache0, new
LogDirFailureChannel(config0.logDirs.size), alterIsrManager)
val rm1 = new ReplicaManager(config1, metrics, time, kafkaZkClient, new
MockScheduler(time), mockLogMgr1,
- new AtomicBoolean(false), QuotaFactory.instantiate(config1, metrics,
time, ""),
+ new AtomicBoolean(false), quotaManager,
Review comment:
the two replica managers are intended to be separate. I used the same
quota manager for both to avoid polluting the method signature/diff. The tests
using this utility function don't rely on any quota manager behavior, so I felt
this was okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
