cadonna commented on a change in pull request #9582:
URL: https://github.com/apache/kafka/pull/9582#discussion_r523061696
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##########
@@ -410,18 +410,6 @@ public final void addSource(final Topology.AutoOffsetReset
offsetReset,
}
}
- for (final Pattern otherPattern : earliestResetPatterns) {
- if (topicPattern.pattern().contains(otherPattern.pattern()) ||
otherPattern.pattern().contains(topicPattern.pattern())) {
- throw new TopologyException("Pattern " + topicPattern + " will
overlap with another pattern " + otherPattern + " already been registered by
another source");
- }
- }
-
- for (final Pattern otherPattern : latestResetPatterns) {
- if (topicPattern.pattern().contains(otherPattern.pattern()) ||
otherPattern.pattern().contains(topicPattern.pattern())) {
- throw new TopologyException("Pattern " + topicPattern + " will
overlap with another pattern " + otherPattern + " already been registered by
another source");
- }
- }
-
Review comment:
Pattern `topic*` is contained in pattern `topic*A`. However, `topic*A`
matches only a subset of `topic*`. So, they do not match exactly the same
topics. But matching exactly the same topics is a pre-requisite for merging the
source nodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
