mjsax commented on a change in pull request #9572:
URL: https://github.com/apache/kafka/pull/9572#discussion_r525533593
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder
internalTopologyBuilder,
rocksDBMetricsRecordingService =
maybeCreateRocksDBMetricsRecordingService(clientId, config);
}
+ private long getCacheSizePerThread(final int numStreamThreads) {
+ return totalCacheSize / (numStreamThreads + ((globalTaskTopology !=
null) ? 1 : 0));
+ }
+
+ private void resizeThreadCache(final int numStreamThreads) {
+ if (numStreamThreads < 0) {
Review comment:
Can it be smaller than `0` ? Should the test be `<= 0` or `< 1` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
