lbradstreet commented on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-729745702
@viktorsomogyi I think a hash collision for the full sized hash will mean that a message is incorrectly cleaned. Are you measuring the collision rate in the probes? I am less worried about those as they are expected, though it's good to know their rate as they will affect performance. Have you measured the rate of collision for the full sized hashes? Those are the main concern when it comes to the safety of this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
