lct45 commented on a change in pull request #9614:
URL: https://github.com/apache/kafka/pull/9614#discussion_r527724338
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##########
@@ -377,7 +378,7 @@ private void shouldAddMetricsOnAllLevels(final String
builtInMetricsVersion) thr
builtInMetricsVersion
);
checkCacheMetrics(builtInMetricsVersion);
-
+ verifyFailedStreamThreadsSensor(0.0);
Review comment:
After looking at both test classes, I think it actually might make the
most sense to put the test for this metric in
`StreamsUncaughtExceptionHandlerIntegrationTest`, since the metric is so
closely aligned with the exception handler anyways and the setup works nicely
with what we're trying to test with the metric. From the size + complexity of
the other test classes, I think creating an overloaded processor for one test
out of 20+ tests seems tricky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
