jolshan commented on a change in pull request #9622:
URL: https://github.com/apache/kafka/pull/9622#discussion_r528407594
##########
File path: clients/src/main/resources/common/message/MetadataRequest.json
##########
@@ -31,9 +31,11 @@
// Starting in version 8, authorized operations can be requested for
cluster and topic resource.
//
// Version 9 is the first flexible version.
+ // Version 10 add topicId
{ "name": "Topics", "type": "[]MetadataRequestTopic", "versions": "0+",
"nullableVersions": "1+",
"about": "The topics to fetch metadata for.", "fields": [
- { "name": "Name", "type": "string", "versions": "0+", "entityType":
"topicName",
+ { "name": "TopicId", "type": "uuid", "versions": "10+", "ignorable":
true, "about": "The topic id." },
+ { "name": "Name", "type": "string", "versions": "0+", "entityType":
"topicName", "ignorable": true,
Review comment:
As discussed in the mailing thread and the KIP writeup, this should be
"nullable" rather than ignorable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
