[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

[GitBox]

ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529101499



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##########
@@ -154,9 +154,9 @@ final void transitionTo(final Task.State newState) {
     }
 
     @Override
-    public void update(final Set<TopicPartition> topicPartitions, final 
Map<String, List<String>> nodeToSourceTopics) {

Review comment:
       Since the root cause of this bug was basically just confusion over what 
exactly this set contains, a renaming feels in order




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org