cadonna commented on a change in pull request #9609: URL: https://github.com/apache/kafka/pull/9609#discussion_r530196629
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.kstream.internals.graph; + +import java.util.Collection; +import java.util.HashSet; +import java.util.Set; +import java.util.regex.Pattern; +import org.apache.kafka.common.serialization.Serde; +import org.apache.kafka.streams.kstream.internals.ConsumedInternal; + +abstract public class SourceGraphNode<K, V> extends StreamsGraphNode { + + private Collection<String> topicNames; + private Pattern topicPattern; + private final ConsumedInternal<K, V> consumedInternal; + + public SourceGraphNode(final String nodeName, + final Collection<String> topicNames, + final ConsumedInternal<K, V> consumedInternal) { + super(nodeName); + + this.topicNames = topicNames; + this.consumedInternal = consumedInternal; + } + + public SourceGraphNode(final String nodeName, + final Pattern topicPattern, + final ConsumedInternal<K, V> consumedInternal) { + + super(nodeName); + + this.topicPattern = topicPattern; + this.consumedInternal = consumedInternal; + } + + public Set<String> topicNames() { + return new HashSet<>(topicNames); Review comment: I like your changes. What I meant is that we could change the constructor of `SourceGraphNode` to: ``` public SourceGraphNode(final String nodeName, final Set<String> topicNames, final ConsumedInternal<K, V> consumedInternal) ``` and the one of `StreamSourceNode` to: ``` public StreamSourceNode(final String nodeName, final Set<String> topicNames, final ConsumedInternal<K, V> consumedInternal) ``` In this way, we have set of topics as soon as possible in the code path from the public API. I think this makes it clearer that it is not possible to have duplicates of topics internally. To keep this PR small, I would propose to just do the changes for `SourceGraphNode`, and do the other changes in a separate PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
