[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

[GitBox]

d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r532337358



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -517,7 +517,9 @@ class KafkaApis(val requestChannel: RequestChannel,
       }
       // Note that authorization to a transactionalId implies ProducerId 
authorization
 
-    } else if (produceRequest.hasIdempotentRecords && 
!authorize(request.context, IDEMPOTENT_WRITE, CLUSTER, CLUSTER_NAME)) {
+    } else if (produceRequest.hasIdempotentRecords
+        && !authorize(request.context, IDEMPOTENT_WRITE, CLUSTER, CLUSTER_NAME)
+        && !authorizeByResourceType(request.context, WRITE, TOPIC)) {

Review comment:
       Right. Deleted the else branch. commit 254af37




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org