hachikuji commented on a change in pull request #9601:
URL: https://github.com/apache/kafka/pull/9601#discussion_r533719708
##########
File path: core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala
##########
@@ -437,8 +437,8 @@ class ReplicaFetcherThreadTest {
thread.doWork()
assertEquals(2, mockNetwork.epochFetchCount)
assertEquals(1, mockNetwork.fetchCount)
- assertEquals("OffsetsForLeaderEpochRequest version.",
- 3, mockNetwork.lastUsedOffsetForLeaderEpochVersion)
+ assertTrue("OffsetsForLeaderEpochRequest version.",
+ mockNetwork.lastUsedOffsetForLeaderEpochVersion >= 3)
Review comment:
I think this was originally using `1` in order to ensure that we were
using a version which included the epoch in the response. Since then it looks
like it has been updated blindly every time we've bumped the protocol. I'm ok
leaving this as is, but we could probably also get rid of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
