dajac commented on a change in pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#discussion_r533999715
##########
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##########
@@ -3727,15 +3733,24 @@ public void testOffsetValidationRequestGrouping() {
assertTrue(expectedPartitions.size() > 0);
allRequestedPartitions.addAll(expectedPartitions);
- Map<TopicPartition, EpochEndOffset> endOffsets =
expectedPartitions.stream().collect(Collectors.toMap(
- Function.identity(),
- tp -> new EpochEndOffset(Errors.NONE, 4, 0)
- ));
+ OffsetForLeaderEpochResponseData data = new
OffsetForLeaderEpochResponseData();
+ expectedPartitions.forEach(tp -> {
+ OffsetForLeaderTopicResult topic =
data.topics().find(tp.topic());
+ if (topic == null) {
Review comment:
That would be nice, indeed! I have been thinking about this as well but
did not have the time to tackle this yet. I have opened a JIRA to track this:
https://issues.apache.org/jira/browse/KAFKA-10795.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
