rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r534563375
##########
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##########
@@ -426,21 +451,35 @@ abstract class AbstractFetcherThread(name: String,
warn(s"Partition $topicPartition marked as failed")
}
- def addPartitions(initialFetchStates: Map[TopicPartition, OffsetAndEpoch]):
Set[TopicPartition] = {
+ /**
+ * Returns initial partition fetch state based on current state and the
provided `initialFetchState`.
+ * From IBP 2.7 onwards, we can rely on truncation based on diverging data
returned in fetch responses.
+ * For older versions, we can skip the truncation step iff the leader epoch
matches the existing epoch.
+ */
+ private def partitionFetchState(tp: TopicPartition, initialFetchState:
InitialFetchState, currentState: PartitionFetchState): PartitionFetchState = {
+ if (currentState != null && currentState.currentLeaderEpoch ==
initialFetchState.currentLeaderEpoch) {
+ currentState
+ } else if (initialFetchState.initOffset < 0) {
+ fetchOffsetAndTruncate(tp, initialFetchState.currentLeaderEpoch)
+ } else if (isTruncationOnFetchSupported) {
+ val lastFetchedEpoch = latestEpoch(tp)
+ val state = if (lastFetchedEpoch.exists(_ !=
EpochEndOffset.UNDEFINED_EPOCH)) Fetching else Truncating
Review comment:
I was being lazy with that check because we were using
`Some(EpochEndOffset.UNDEFINED_EPOCH)` in AbstractFetcherThreadTest. I have
updated the test and fixed the check. Added comment as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
