guozhangwang commented on a change in pull request #9276: URL: https://github.com/apache/kafka/pull/9276#discussion_r535511409
########## File path: docs/ops.html ########## @@ -1129,6 +1128,26 @@ <h4><a id="remote_jmx" href="#remote_jmx">Security Considerations for Remote Mon <td>kafka.server:type=BrokerTopicMetrics,name=ReassignmentBytesInPerSec</td> <td></td> </tr> + <tr> + <td>Size of a partition on disk (in bytes)</td> + <td>kafka.log:type=Log,name=Size,topic=([-.\w]+),partition=([0-9]+)</td> + <td>The size of a partition on disk, measured in bytes.</td> + </tr> + <tr> + <td>Number of log segments in a partition</td> + <td>kafka.log:type=Log,name=NumLogSegments,topic=([-.\w]+),partition=([0-9]+)</td> + <td>The number of log segments in a partition.</td> Review comment: I think this is fine :) ########## File path: docs/ops.html ########## @@ -1129,6 +1128,26 @@ <h4><a id="remote_jmx" href="#remote_jmx">Security Considerations for Remote Mon <td>kafka.server:type=BrokerTopicMetrics,name=ReassignmentBytesInPerSec</td> <td></td> </tr> + <tr> + <td>Size of a partition on disk (in bytes)</td> + <td>kafka.log:type=Log,name=Size,topic=([-.\w]+),partition=([0-9]+)</td> + <td>The size of a partition on disk, measured in bytes.</td> + </tr> + <tr> + <td>Number of log segments in a partition</td> + <td>kafka.log:type=Log,name=NumLogSegments,topic=([-.\w]+),partition=([0-9]+)</td> + <td>The number of log segments in a partition.</td> + </tr> + <tr> + <td>First offset in a partition</td> + <td>kafka.log:type=Log,name=LogStartOffset,topic=([-.\w]+),partition=([0-9]+)</td> + <td>The first offset in a partition.</td> + </tr> + <tr> + <td>Last offset in a partition</td> + <td>kafka.log:type=Log,name=LogEndOffset,topic=([-.\w]+),partition=([0-9]+)</td> + <td>The last offset in a partition.</td> Review comment: This is the last uncomitted offset: after the local append it would be incremented, not waiting for other replicas to ack. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org