tombentley commented on a change in pull request #9676:
URL: https://github.com/apache/kafka/pull/9676#discussion_r535972740
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1219,6 +1219,9 @@ class Log(@volatile private var _dir: File,
appendInfo.logAppendTime = duplicate.timestamp
appendInfo.logStartOffset = logStartOffset
case None =>
+ if (logDirFailureChannel.logDirIsOffline(parentDir)) {
+ throw new KafkaStorageException(s"The log dir $parentDir has
failed.");
Review comment:
@guozhangwang good point. I also changed the language to 'offline'
rather than 'failed', since this is more consistent with other usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
