rhauch commented on a change in pull request #9698:
URL: https://github.com/apache/kafka/pull/9698#discussion_r537599704
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##########
@@ -194,20 +224,27 @@ private void
waitUntilMirrorMakerIsRunning(EmbeddedConnectCluster connectCluster
@After
public void close() {
- for (String x : primary.connectors()) {
- primary.deleteConnector(x);
- }
- for (String x : backup.connectors()) {
- backup.deleteConnector(x);
- }
- deleteAllTopics(primary.kafka());
- deleteAllTopics(backup.kafka());
- primary.stop();
- backup.stop();
try {
- assertFalse(exited.get());
+ for (String x : primary.connectors()) {
+ primary.deleteConnector(x);
+ }
+ for (String x : backup.connectors()) {
+ backup.deleteConnector(x);
+ }
+ deleteAllTopics(primary.kafka());
+ deleteAllTopics(backup.kafka());
} finally {
- Exit.resetExitProcedure();
+ shuttingDown = true;
+ try {
+ try {
+ primary.stop();
Review comment:
`EmbeddedConnectCluster` is not `AutoCloseable`, which means we can't
use that. Since this PR is to fix broken builds, I'd like to minimize the
additional changes, so I'll issue a followup PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
