cadonna commented on a change in pull request #9696:
URL: https://github.com/apache/kafka/pull/9696#discussion_r538808666
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -235,11 +235,7 @@ public final Sensor threadLevelSensor(final String
threadId,
final String key = threadSensorPrefix(threadId);
synchronized (threadLevelSensors) {
final String fullSensorName = key + SENSOR_NAME_DELIMITER +
sensorName;
Review comment:
I think you can also drag this line into `getSensor()`. Sorry for not
noticing before.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -926,6 +905,19 @@ public static void maybeMeasureLatency(final Runnable
actionToMeasure,
}
}
+ private Sensor getSensors(final Map<String, Deque<String>> sensors,
+ final String fullSensorName,
+ final String key,
+ final RecordingLevel recordingLevel,
+ final Sensor... parents) {
Review comment:
nit: Could you fix the indentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
