[GitHub] [kafka] chia7712 commented on a change in pull request #9694: MINOR: Change the input type of DescribeAclsResponse#aclsResources from Collection to Iterable to avoid creating useless collection

[GitBox]

chia7712 commented on a change in pull request #9694:
URL: https://github.com/apache/kafka/pull/9694#discussion_r539416849



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -2509,12 +2509,10 @@ class KafkaApis(val requestChannel: RequestChannel,
             .setThrottleTimeMs(requestThrottleMs)))
       case Some(auth) =>
         val filter = describeAclsRequest.filter
-        val returnedAcls = new util.HashSet[AclBinding]()
-        auth.acls(filter).forEach(returnedAcls.add)

Review comment:
       Good point! It seems to me the method ```aclsResources``` should 
de-duplicate as it tries to traverse all elements from input
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org