ijuma commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r540191647
########## File path: clients/src/main/java/org/apache/kafka/common/network/TransferableChannel.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.network; + +import java.io.IOException; +import java.nio.channels.FileChannel; +import java.nio.channels.GatheringByteChannel; + +/** + * TransportLayer is a fat interface so it is a bit weird to use TransportLayer in write-only path. + * Hence, we extract all write-related methods from TransportLayer to be a new interface - TransferableChannel Review comment: I would replace this comment with: > Extends `GatheringByteChannel` with the minimal set of methods required by the `Send` interface. Supporting TLS and efficient `zero copy` transfers are the main reasons for the additional methods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
