[ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248495#comment-17248495 ]
GeordieMai commented on KAFKA-10841: ------------------------------------ Hello , I'm a newbie too . So please let me do it . I have written it and try to know the failed test is related or not . > LogReadResult should be able to converted to FetchPartitionData > ---------------------------------------------------------------- > > Key: KAFKA-10841 > URL: https://issues.apache.org/jira/browse/KAFKA-10841 > Project: Kafka > Issue Type: Improvement > Reporter: Chia-Ping Tsai > Assignee: GeordieMai > Priority: Minor > Labels: newbie > > There are duplicate code which try to convert LogReadResult to > FetchPartitionData. It seems to me the duplicate code can be eliminated by > moving the conversion to LogReadResult. > occurrence 1: > https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L1076 > occurrence 2: > https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/DelayedFetch.scala#L189 > -- This message was sent by Atlassian Jira (v8.3.4#803005)