d8tltanc edited a comment on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-743884225
@rajinisivaram Thanks for another round of detailed review. I've 1. Add the corner case checks in AclAuthorizer when there's no deny ACL binding in AclAuthorizer. 2. Re-write the AclWrapper logic to use the `BaseAuthorizer` to give the information about if we should "allow everyone if no ACL found" in the configure() method. 3. Fix the "canDenyAll" logic in AclWrapper. 4. Revert the unnecessary changes in the tests and benchmark. There're a few outstanding comments that need further discussion as I replied, mostly the NIT changes. Please let me know what you think about those. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
