chia7712 commented on a change in pull request #9748:
URL: https://github.com/apache/kafka/pull/9748#discussion_r542972073
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##########
@@ -289,49 +129,40 @@ public Struct parseResponse(short version, ByteBuffer
buffer) {
/** indicates whether the API is enabled for forwarding **/
public final boolean forwardable;
- public final Schema[] requestSchemas;
- public final Schema[] responseSchemas;
public final boolean requiresDelayedAllocation;
- ApiKeys(int id, String name, Schema[] requestSchemas, Schema[]
responseSchemas) {
- this(id, name, false, requestSchemas, responseSchemas);
- }
+ public final ApiMessageType messageType;
- ApiKeys(int id, String name, boolean clusterAction, Schema[]
requestSchemas, Schema[] responseSchemas) {
- this(id, name, clusterAction, RecordBatch.MAGIC_VALUE_V0,
requestSchemas, responseSchemas);
+ ApiKeys(ApiMessageType messageType) {
+ this(messageType, false);
}
- ApiKeys(int id, String name, Schema[] requestSchemas, Schema[]
responseSchemas, boolean forwardable) {
- this(id, name, false, RecordBatch.MAGIC_VALUE_V0, true,
requestSchemas, responseSchemas, forwardable);
+ ApiKeys(ApiMessageType messageType, boolean clusterAction) {
+ this(messageType, clusterAction, RecordBatch.MAGIC_VALUE_V0, false);
}
- ApiKeys(int id, String name, boolean clusterAction, boolean isEnabled,
Schema[] requestSchemas, Schema[] responseSchemas) {
- this(id, name, clusterAction, RecordBatch.MAGIC_VALUE_V0, isEnabled,
requestSchemas, responseSchemas, false);
+ ApiKeys(ApiMessageType messageType, boolean clusterAction, boolean
forwardable) {
+ this(messageType, clusterAction, RecordBatch.MAGIC_VALUE_V0,
forwardable);
}
- ApiKeys(int id, String name, boolean clusterAction, byte
minRequiredInterBrokerMagic,
- Schema[] requestSchemas, Schema[] responseSchemas) {
- this(id, name, clusterAction, minRequiredInterBrokerMagic, true,
requestSchemas, responseSchemas, false);
+ ApiKeys(ApiMessageType messageType, boolean clusterAction, byte
minRequiredInterBrokerMagic, boolean forwardable) {
+ this(messageType, clusterAction, minRequiredInterBrokerMagic,
forwardable, true);
}
ApiKeys(
- int id,
- String name,
+ ApiMessageType messageType,
boolean clusterAction,
byte minRequiredInterBrokerMagic,
- boolean isEnabled,
- Schema[] requestSchemas,
- Schema[] responseSchemas,
- boolean forwardable
+ boolean forwardable,
+ boolean isEnabled
) {
+ short id = messageType.apiKey();
Review comment:
It seems to me this check should be moved to
```ApiMessageTypeGenerator``` as it is a generated code from json.
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##########
@@ -289,49 +129,40 @@ public Struct parseResponse(short version, ByteBuffer
buffer) {
/** indicates whether the API is enabled for forwarding **/
public final boolean forwardable;
- public final Schema[] requestSchemas;
- public final Schema[] responseSchemas;
public final boolean requiresDelayedAllocation;
- ApiKeys(int id, String name, Schema[] requestSchemas, Schema[]
responseSchemas) {
- this(id, name, false, requestSchemas, responseSchemas);
- }
+ public final ApiMessageType messageType;
- ApiKeys(int id, String name, boolean clusterAction, Schema[]
requestSchemas, Schema[] responseSchemas) {
- this(id, name, clusterAction, RecordBatch.MAGIC_VALUE_V0,
requestSchemas, responseSchemas);
+ ApiKeys(ApiMessageType messageType) {
+ this(messageType, false);
}
- ApiKeys(int id, String name, Schema[] requestSchemas, Schema[]
responseSchemas, boolean forwardable) {
- this(id, name, false, RecordBatch.MAGIC_VALUE_V0, true,
requestSchemas, responseSchemas, forwardable);
+ ApiKeys(ApiMessageType messageType, boolean clusterAction) {
+ this(messageType, clusterAction, RecordBatch.MAGIC_VALUE_V0, false);
}
- ApiKeys(int id, String name, boolean clusterAction, boolean isEnabled,
Schema[] requestSchemas, Schema[] responseSchemas) {
- this(id, name, clusterAction, RecordBatch.MAGIC_VALUE_V0, isEnabled,
requestSchemas, responseSchemas, false);
+ ApiKeys(ApiMessageType messageType, boolean clusterAction, boolean
forwardable) {
+ this(messageType, clusterAction, RecordBatch.MAGIC_VALUE_V0,
forwardable);
}
- ApiKeys(int id, String name, boolean clusterAction, byte
minRequiredInterBrokerMagic,
- Schema[] requestSchemas, Schema[] responseSchemas) {
- this(id, name, clusterAction, minRequiredInterBrokerMagic, true,
requestSchemas, responseSchemas, false);
+ ApiKeys(ApiMessageType messageType, boolean clusterAction, byte
minRequiredInterBrokerMagic, boolean forwardable) {
+ this(messageType, clusterAction, minRequiredInterBrokerMagic,
forwardable, true);
}
ApiKeys(
- int id,
- String name,
+ ApiMessageType messageType,
boolean clusterAction,
byte minRequiredInterBrokerMagic,
- boolean isEnabled,
- Schema[] requestSchemas,
- Schema[] responseSchemas,
- boolean forwardable
+ boolean forwardable,
+ boolean isEnabled
) {
+ short id = messageType.apiKey();
if (id < 0)
throw new IllegalArgumentException("id must not be negative, id: "
+ id);
- this.id = (short) id;
- this.name = name;
- this.clusterAction = clusterAction;
- this.minRequiredInterBrokerMagic = minRequiredInterBrokerMagic;
- this.isEnabled = isEnabled;
+ Schema[] requestSchemas = messageType.requestSchemas();
+ Schema[] responseSchemas = messageType.responseSchemas();
+ String name = messageType.name;
if (requestSchemas.length != responseSchemas.length)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
