mjsax commented on a change in pull request #9733:
URL: https://github.com/apache/kafka/pull/9733#discussion_r543954728
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##########
@@ -256,8 +261,8 @@ public void shouldUpgradeFromEosAlphaToEosBeta() throws
Exception {
streams2Alpha.cleanUp();
streams2Alpha.start();
assignmentListener.waitForNextStableAssignment(MAX_WAIT_TIME_MS);
Review comment:
> The line number is not mapped to master branch correctly, but you can
know what it is from the method name.
Well, this seem to imply the the run was on an older version that did not
contain the retry yet -- note. adding the retry it was part of the latest PR
for this test that we merged:
https://github.com/apache/kafka/pull/9688/files#diff-86a5136ae170df067137442b5eae05fa5fd9d1e02aca85bac8a251b7d2557b0eR1089
Thus, I would assume the the whole test failure you observes was before the
last fix.
> there will be 2 rebalance happened
Correct, but we actually "cut off" the unstable rebalances (there might
actually be more then 2...) via
`assignmentListener.waitForNextStableAssignment(MAX_WAIT_TIME_MS);`
To me, it seems that you observe the test failure before the PR got merged
-- otherwise the line numbers for `keysFromInstance` would match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
