mjsax commented on a change in pull request #9606:
URL: https://github.com/apache/kafka/pull/9606#discussion_r548180364
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedCogroupedKStream.java
##########
@@ -77,7 +77,8 @@
* {@link StreamsConfig#CACHE_MAX_BYTES_BUFFERING_CONFIG cache size}, and
* {@link StreamsConfig#COMMIT_INTERVAL_MS_CONFIG commit intervall}.
* <p>
- * For failure and recovery the store will be backed by an internal
changelog topic that will be created in Kafka.
+ * For failure and recovery the store (which always will be of type {@link
TimestampedKeyValueStore}) will be backed by
Review comment:
For time-windows, it would be a `TimestampedWindowStore` (not
tkv-store). (same below for the other method of this class)
Note the signature of `Materialized<K, V, WindowStore<Bytes, byte[]>>` that
uses `WindowStore`, not `KeyValueStore`.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java
##########
@@ -67,7 +67,8 @@
* {@link StreamsConfig#CACHE_MAX_BYTES_BUFFERING_CONFIG cache size}, and
* {@link StreamsConfig#COMMIT_INTERVAL_MS_CONFIG commit intervall}.
* <p>
- * For failure and recovery the store will be backed by an internal
changelog topic that will be created in Kafka.
+ * For failure and recovery the store (which always will be of type {@link
TimestampedKeyValueStore}) will be backed by
Review comment:
As above. Should we `TimestampedWindowStore` for this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
