chia7712 commented on a change in pull request #9785: URL: https://github.com/apache/kafka/pull/9785#discussion_r548481521
########## File path: build.gradle ########## @@ -1782,8 +1782,8 @@ project(':log4j-appender') { compile libs.slf4jlog4j testCompile project(':clients').sourceSets.test.output - testCompile libs.junitJupiterApi - testCompile libs.junitVintageEngine + testCompile libs.junitJupiter + testCompile libs.hamcrest Review comment: @ijuma Should we remove hamcrest? Removing it causes a bigger patch. The benefit of removing it is that our test assert get more consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org