mjsax commented on pull request #9800: URL: https://github.com/apache/kafka/pull/9800#issuecomment-754980147
> which part of the change is triggering a retry of TX commit? The main processing loop does, ie, we don't really need any change to get a retry. In each loop we iterate over all tasks, and if the tasks flag "needCommit" is set to `true` it would retry to commit the task (note, that we don't reset the flag to `false` if we hit a timeout) when commit-interval-ms passed. I though it's ok to just "pause" processing for a full commit interval for this case -- we could of course also set `commitRequested=true` to retry the commit directly in the next iteration instead of waiting for the next commit-interval to pass. Thoughts? > I assume isProcessable will return false once we are already within a transaction No. Before this change, `isProcessable()` returns `true` if there is available data in our internal buffer. It does not know anything about TX. > how could we break out of this check Not sure if I can follow? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
