[GitHub] [kafka] dongjinleekr commented on a change in pull request #9420: KAFKA-10604: The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

[GitBox]

dongjinleekr commented on a change in pull request #9420:
URL: https://github.com/apache/kafka/pull/9420#discussion_r553355399



##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -602,7 +603,7 @@
                     REPLICATION_FACTOR_DOC)
             .define(STATE_DIR_CONFIG,
                     Type.STRING,
-                    "/tmp/kafka-streams",
+                    
Utils.getTempDir().resolve("kafka-streams").toAbsolutePath().toString(),

Review comment:
       @vvcephei @mjsax Totally agree. Since I am now finalizing KAFKA-8403 
now, I will fix this with a integration test after that. 🙏




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org