dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r556176373
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/TopicDescription.java
##########
@@ -62,25 +62,25 @@ public int hashCode() {
* leadership and replica information for that partition.
*/
public TopicDescription(String name, boolean internal,
List<TopicPartitionInfo> partitions) {
- this(name, internal, partitions, Collections.emptySet());
+ this(name, Uuid.ZERO_UUID, internal, partitions);
+ }
+
+ public TopicDescription(String name, Uuid topicId, boolean internal,
List<TopicPartitionInfo> partitions) {
+ this(name, topicId, internal, partitions, Collections.emptySet());
}
/**
* Create an instance with the specified parameters.
*
* @param name The topic name
+ * @param topicId the topic id
* @param internal Whether the topic is internal to Kafka
* @param partitions A list of partitions where the index represents the
partition id and the element contains
* leadership and replica information for that partition.
* @param authorizedOperations authorized operations for this topic, or
null if this is not known.
*/
- public TopicDescription(String name, boolean internal,
List<TopicPartitionInfo> partitions,
+ public TopicDescription(String name, Uuid topicId, boolean internal,
List<TopicPartitionInfo> partitions,
Review comment:
This is also my mistake, I tried to add a constructor but remove one, I
have rollbacked the removing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
