[ https://issues.apache.org/jira/browse/KAFKA-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chia-Ping Tsai updated KAFKA-12187: ----------------------------------- Description: see [https://github.com/apache/kafka/pull/9874#discussion_r556547909] {quote}Yeah, for existing code improvements (versus code introduced by this change), let's do it via a different PR. For this particular issue, we can probably wait for JUnit 5.8 and use: {quote} * New assertInstanceOf methods as a replacement for assertTrue(obj instanceof X) which provide better error messages comparable to those of assertThrows. related PR: https://github.com/junit-team/junit5/pull/2499 was: see https://github.com/apache/kafka/pull/9874#discussion_r556547909 {quote} Yeah, for existing code improvements (versus code introduced by this change), let's do it via a different PR. For this particular issue, we can probably wait for JUnit 5.8 and use: {quote} * New assertInstanceOf methods as a replacement for assertTrue(obj instanceof X) which provide better error messages comparable to those of assertThrows.{quote} {quote} > replace assertTrue(obj instanceof X) by assertInstanceOf when we update to > JUnit 5.8 > ------------------------------------------------------------------------------------ > > Key: KAFKA-12187 > URL: https://issues.apache.org/jira/browse/KAFKA-12187 > Project: Kafka > Issue Type: Improvement > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Priority: Minor > > see [https://github.com/apache/kafka/pull/9874#discussion_r556547909] > > {quote}Yeah, for existing code improvements (versus code introduced by this > change), let's do it via a different PR. For this particular issue, we can > probably wait for JUnit 5.8 and use: > {quote} > * New assertInstanceOf methods as a replacement for assertTrue(obj instanceof > X) which provide better error messages comparable to those of assertThrows. > related PR: https://github.com/junit-team/junit5/pull/2499 -- This message was sent by Atlassian Jira (v8.3.4#803005)