chia7712 commented on a change in pull request #9874:
URL: https://github.com/apache/kafka/pull/9874#discussion_r556624536
##########
File path:
clients/src/test/java/org/apache/kafka/common/record/FileLogInputStreamTest.java
##########
@@ -210,22 +246,24 @@ public void testBatchIterationIncompleteBatch() throws
IOException {
FileChannelRecordBatch firstBatch = logInputStream.nextBatch();
assertNoProducerData(firstBatch);
- assertGenericRecordBatchData(firstBatch, 0L, 100L,
firstBatchRecord);
+ assertGenericRecordBatchData(args, firstBatch, 0L, 100L,
firstBatchRecord);
assertNull(logInputStream.nextBatch());
}
}
- @Test
- public void testNextBatchSelectionWithMaxedParams() throws IOException {
+ @ParameterizedTest
+ @ArgumentsSource(FileLogInputStreamArgumentsProvider.class)
+ public void testNextBatchSelectionWithMaxedParams(Args args) throws
IOException {
Review comment:
unnecessary ```ParameterizedTest```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
