[GitHub] [kafka] highluck commented on a change in pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

[GitBox]

highluck commented on a change in pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#discussion_r557004076



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##########
@@ -53,16 +56,17 @@
     private final Map<TopicPartition, String> ownedPartitions = new 
TreeMap<>(TOPIC_PARTITION_COMPARATOR);
     private final Map<String, Set<TaskId>> consumerToPreviousStatefulTaskIds = 
new TreeMap<>();
 
-    // the following four maps are used only for logging purposes;
-    // TODO KAFKA-10283: we could consider merging them with other 
book-keeping maps at client-levels
-    //                   so that they would not be inconsistent

Review comment:
       Oh, I was misunderstanding
   @ableegoldman 
   
   Integrating two structures, for example
   
   `class ClientStateTask {
      private final Set<TaskId> clientTaskIds
     private filnal Map<String, Set<TaskId>> consumerTaskIds
   }`
   
   Is this form correct?
   thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org