ijuma commented on a change in pull request #9715: URL: https://github.com/apache/kafka/pull/9715#discussion_r557461217
########## File path: core/src/main/scala/kafka/server/RequestHandlerUtils.scala ########## @@ -0,0 +1,203 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kafka.server + +import kafka.cluster.Partition +import kafka.coordinator.group.GroupCoordinator +import kafka.coordinator.transaction.TransactionCoordinator + +import java.lang.{Byte => JByte} +import java.util.Collections +import kafka.network.RequestChannel +import kafka.security.authorizer.AclEntry +import kafka.server.QuotaFactory.QuotaManagers +import kafka.utils.Logging +import org.apache.kafka.common.acl.AclOperation +import org.apache.kafka.common.errors.ClusterAuthorizationException +import org.apache.kafka.common.internals.Topic +import org.apache.kafka.common.network.Send +import org.apache.kafka.common.requests.{AbstractRequest, AbstractResponse, RequestContext} +import org.apache.kafka.common.resource.Resource.CLUSTER_NAME +import org.apache.kafka.common.resource.ResourceType.CLUSTER +import org.apache.kafka.common.resource.{PatternType, Resource, ResourcePattern, ResourceType} +import org.apache.kafka.common.utils.{Time, Utils} +import org.apache.kafka.server.authorizer.{Action, AuthorizationResult, Authorizer} + +import scala.jdk.CollectionConverters._ + +/** + * Helper methods for request handlers + */ +object RequestHandlerUtils { + def onLeadershipChange(groupCoordinator: GroupCoordinator, + txnCoordinator: TransactionCoordinator, + updatedLeaders: Iterable[Partition], + updatedFollowers: Iterable[Partition]): Unit = { + // for each new leader or follower, call coordinator to handle consumer group migration. + // this callback is invoked under the replica state change lock to ensure proper order of + // leadership changes + updatedLeaders.foreach { partition => + if (partition.topic == Topic.GROUP_METADATA_TOPIC_NAME) + groupCoordinator.onElection(partition.partitionId) + else if (partition.topic == Topic.TRANSACTION_STATE_TOPIC_NAME) + txnCoordinator.onElection(partition.partitionId, partition.getLeaderEpoch) + } + + updatedFollowers.foreach { partition => + if (partition.topic == Topic.GROUP_METADATA_TOPIC_NAME) + groupCoordinator.onResignation(partition.partitionId) + else if (partition.topic == Topic.TRANSACTION_STATE_TOPIC_NAME) + txnCoordinator.onResignation(partition.partitionId, Some(partition.getLeaderEpoch)) + } + } +} + +class AuthHelper(val requestChannel: RequestChannel, + val authorizer: Option[Authorizer]) { + def authorize(requestContext: RequestContext, + operation: AclOperation, + resourceType: ResourceType, + resourceName: String, + logIfAllowed: Boolean = true, + logIfDenied: Boolean = true, + refCount: Int = 1): Boolean = { + authorizer.forall { authZ => + val resource = new ResourcePattern(resourceType, resourceName, PatternType.LITERAL) + val actions = Collections.singletonList(new Action(operation, resource, refCount, logIfAllowed, logIfDenied)) + authZ.authorize(requestContext, actions).get(0) == AuthorizationResult.ALLOWED + } + } + + def authorizeClusterOperation(request: RequestChannel.Request, operation: AclOperation): Unit = { + if (!authorize(request.context, operation, CLUSTER, CLUSTER_NAME)) + throw new ClusterAuthorizationException(s"Request $request is not authorized.") + } + + def authorizedOperations(request: RequestChannel.Request, resource: Resource): Int = { + val supportedOps = AclEntry.supportedOperations(resource.resourceType).toList + val authorizedOps = authorizer match { + case Some(authZ) => + val resourcePattern = new ResourcePattern(resource.resourceType, resource.name, PatternType.LITERAL) + val actions = supportedOps.map { op => new Action(op, resourcePattern, 1, false, false) } + authZ.authorize(request.context, actions.asJava).asScala + .zip(supportedOps) + .filter(_._1 == AuthorizationResult.ALLOWED) + .map(_._2).toSet + case None => + supportedOps.toSet + } + Utils.to32BitField(authorizedOps.map(operation => operation.code.asInstanceOf[JByte]).asJava) + } +} + +class ChannelHelper(val requestChannel: RequestChannel, Review comment: Should this be `RequestHandlerHelper` then? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
