[GitHub] [kafka] cmccabe commented on a change in pull request #9876: KAFKA-12183: Add the KIP-631 metadata record definitions

[GitBox]

cmccabe commented on a change in pull request #9876:
URL: https://github.com/apache/kafka/pull/9876#discussion_r557580624



##########
File path: build.gradle
##########
@@ -1010,6 +1015,53 @@ project(':core') {
   }
 }
 
+project(':metadata') {
+  archivesBaseName = "kafka-metadata"
+
+  dependencies {
+    compile project(':clients')
+    compile libs.jacksonDatabind
+    compile libs.jacksonJDK8Datatypes
+    compileOnly libs.log4j
+    testCompile libs.junitJupiter
+    testCompile libs.hamcrest
+    testCompile libs.slf4jlog4j
+    testCompile project(':clients').sourceSets.test.output // for 
org.apache.kafka.test.IntegrationTest

Review comment:
       later PRs add IntegrationTest to the metadata module... simpler to just 
keep it in this PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org