abbccdda commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r557825070
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -139,8 +138,11 @@ class KafkaApis(val requestChannel: RequestChannel,
request: RequestChannel.Request,
handler: RequestChannel.Request => Unit
): Unit = {
- def responseCallback(response: AbstractResponse): Unit = {
- sendForwardedResponse(request, response)
+ def responseCallback(responseEither: Either[AbstractResponse, Errors]):
Unit = {
+ responseEither match {
+ case Left(response) => sendForwardedResponse(request, response)
+ case Right(error) => closeConnection(request,
Collections.singletonMap(error, 1))
Review comment:
Sg, I prefer using `info` here since it should be a rare case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
