hachikuji commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557829548
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -2216,7 +2316,7 @@ public void complete() {
// These fields are visible to both the Raft IO thread and the listener
// and are protected through synchronization on this `ListenerContext`
instance
private BatchReader<T> lastSent = null;
- private long lastAckedOffset = 0;
+ private long lastAckedEndOffset = 0;
Review comment:
I don't feel too strongly about it, but the new name is a little
confusing to me. Why would the client only be acking end offsets? Especially
confusing when I see this: `lastAckedEndOffset = logStartOffset` 🙂 . I think
we probably need a comment here regardless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
